Eli Mesika has posted comments on this change. Change subject: core: Added the table vds_deloy_config ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27028/6/packaging/dbscripts/inst_sp.sql File packaging/dbscripts/inst_sp.sql: Line 81: -- Adds the vds deploy configuration if it does not exist already else updates the existing one Line 82: Create or replace FUNCTION inst_add_update_vds_deploy_config(v_cfg_name VARCHAR(50), v_cfg_type VARCHAR(30), v_cfg_value VARCHAR(50), v_host VARCHAR(128), INOUT v_cfg_id INTEGER) RETURNS SETOF INTEGER Line 83: AS $procedure$ Line 84: BEGIN Line 85: if exists (select 1 from vds_deploy_config where cfg_name=v_cfg_name) then potential race here you should add before the BEGIN LOCK TABLE vds_deploy_config IN SHARE ROW EXCLUSIVE MODE; Line 86: update vds_deploy_config set cfg_type=v_cfg_type, cfg_value=v_cfg_value, host = v_host where cfg_name=v_cfg_name; Line 87: else Line 88: insert into vds_deploy_config(cfg_name, cfg_type, cfg_value, host) values(v_cfg_name, v_cfg_type, v_cfg_value, v_host); Line 89: v_cfg_id := CURRVAL('vds_deploy_config_seq'); -- To view, visit http://gerrit.ovirt.org/27028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc58b36dccfd23165dd5b0dfb7c2c86cf261f488 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
