Roy Golan has posted comments on this change.

Change subject: backend: RNG device sources reporting
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/22258/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRngDeviceCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRngDeviceCommand.java:

Line 36:             addCustomValue("ErrorMessage", String.format("RNG Device 
id: %s of VM id: %s  is no more compatible with cluster. Removing the device.",
Line 37:                     device.getId(), device.getVmId()));
Line 38:             AuditLogDirector.log(this, 
AuditLogType.RNG_SOURCES_INCOMPATIBLE_WITH_CLUSTER);
Line 39:         }
Line 40: 
the device you updating is the device your removing?
Line 41:         VmDevice rngDevice = getParameters().getRngDevice();
Line 42:         getDbFacade().getVmDeviceDao().update(rngDevice);
Line 43:         setSucceeded(true);
Line 44:     }


-- 
To view, visit http://gerrit.ovirt.org/22258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id60a39118aef439146e6f0f308eec84e1ccaab9a
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to