Lior Vernia has posted comments on this change. Change subject: core: Add Predefined bridge_opts network custom property ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/26651/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 241: String networkName = iface.getNetworkName(); Line 242: if (iface.getCustomProperties() != null) { Line 243: if (!networkCustomPropertiesSupported) { Line 244: addViolation(VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_CUSTOM_PROPERTIES_NOT_SUPPORTED, networkName); Line 245: } else if (!util.validateProperties(existingClusterNetworks.get(networkName).isVmNetwork() ? validProperties > if networkName is null, NPE will follow Done Line 246: : validPropertiesNonVm, Line 247: iface.getCustomProperties()) Line 248: .isEmpty()) { Line 249: addViolation(VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_CUSTOM_PROPERTIES_BAD_INPUT, networkName); -- To view, visit http://gerrit.ovirt.org/26651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fd1045ff89ec46ae486859627702ec740819b0a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
