Livnat Peer has posted comments on this change. Change subject: core: SN: Send only removed bonds (#824839) ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) I hope you'll send a patch to fix the tests soon. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java Line 252: } Please add a comment to explain the logic, especially the idea that if a bond exist on the host but has no slaves we do not send a delete command for it. -- To view, visit http://gerrit.ovirt.org/4929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b886e30e685532e03a46d2b31749d3b124fc7b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
