Maor Lipchuk has uploaded a new change for review. Change subject: webadmin: general Storage sub tab should be updated for iSCSI ......................................................................
webadmin: general Storage sub tab should be updated for iSCSI iSCSI Storage Domain general sub tab should be updated when the Storage Domain is extended. Change-Id: I3a0a00c0c92a515ffc8786db75663139af904e92 Signed-off-by: Maor Lipchuk <[email protected]> Bug-Url: https://bugzilla.redhat.com/1075515 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java 1 file changed, 23 insertions(+), 28 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/31/27231/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java index 8f7df19..a301eda 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java @@ -166,38 +166,33 @@ setIsLocalS(storageDomain.getStorageType() == StorageType.LOCALFS); setIsPosix(storageDomain.getStorageType() == StorageType.POSIXFS); - if (getIsNfs() || getIsLocalS() || getIsPosix()) - { - AsyncQuery _asyncQuery = new AsyncQuery(); - _asyncQuery.setModel(this); - _asyncQuery.asyncCallback = new INewAsyncCallback() { - @Override - public void onSuccess(Object model, Object ReturnValue) - { - StorageServerConnections connection = (StorageServerConnections) ReturnValue; - StorageGeneralModel generalModel = (StorageGeneralModel) model; + AsyncQuery _asyncQuery = new AsyncQuery(); + _asyncQuery.setModel(this); + _asyncQuery.asyncCallback = new INewAsyncCallback() { + @Override + public void onSuccess(Object model, Object ReturnValue) + { + StorageServerConnections connection = (StorageServerConnections) ReturnValue; + StorageGeneralModel generalModel = (StorageGeneralModel) model; - generalModel.setPath(connection == null ? null : connection.getconnection()); + generalModel.setPath(connection == null ? null : connection.getconnection()); - if (isNfs) { - generalModel.setNfsVersion(connection.getNfsVersion()); - generalModel.setRetransmissions(connection.getNfsRetrans()); - generalModel.setTimeout(connection.getNfsTimeo()); - } - - if (isPosix) { - generalModel.setVfsType(connection.getVfsType()); - generalModel.setMountOptions(connection.getMountOptions()); - } + if (isNfs) { + generalModel.setNfsVersion(connection.getNfsVersion()); + generalModel.setRetransmissions(connection.getNfsRetrans()); + generalModel.setTimeout(connection.getNfsTimeo()); } - }; - AsyncDataProvider.getStorageConnectionById(_asyncQuery, storageDomain.getStorage(), true); - } - else - { - setPath(null); - } + if (isPosix) { + generalModel.setVfsType(connection.getVfsType()); + generalModel.setMountOptions(connection.getMountOptions()); + } + if (!getIsNfs() && !getIsLocalS() && !getIsPosix()) { + setPath(null); + } + } + }; + AsyncDataProvider.getStorageConnectionById(_asyncQuery, storageDomain.getStorage(), true); } } -- To view, visit http://gerrit.ovirt.org/27231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3a0a00c0c92a515ffc8786db75663139af904e92 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
