Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: iSCSI support ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/26501/12/src/plugins/ovirt-hosted-engine-setup/storage/storage.py File src/plugins/ovirt-hosted-engine-setup/storage/storage.py: Line 237: ohostedcons.StorageEnv.SD_UUID Line 238: ] Line 239: ) Line 240: self._handleHostId() Line 241: # FIXME: I'm not really sure this is enough. It wasn't enough, fixed. Line 242: elif self.storageType in ( Line 243: ohostedcons.VDSMConstants.NFS_DOMAIN, Line 244: ohostedcons.VDSMConstants.GLUSTERFS_DOMAIN, Line 245: ): -- To view, visit http://gerrit.ovirt.org/26501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide79a130b730d95d3545dcfb80b1b01dfeaf2b12 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
