Einav Cohen has posted comments on this change.
Change subject: webadmin: USB Support
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
Line 86: private UsbPolicy usbPolicy = UsbPolicy.DISABLED;
please make sure that engine-core and rest-api maintainers will take a look at
this change as well - it can cause behavioural changes in engine-core and
rest-api - not sure if these changes are desired.
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
Line 221:
some white-spaces were added here - any reason?
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
Line 99: }
Is the above a treatment for the "Blank" template? If so, why shouldn't we
retrieve its UsbPolicy and set it in the Model just like we would have for any
other template?
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 1266: if
(Version.v3_0.compareTo(cluster.getcompatibility_version()) >= 0) {
Instead of checking if the cluster-version <= 3.0, I suggest to check that it
is < 3.1 (or even do an "if... else..." with the "if
(Version.v3_1.compareTo(cluster.getcompatibility_version()) <= 0)" statement
below).
Although probably won't happen: If, for some reason, there will be a cluster
version 3.0.5, it should still be considered as 3.0; i.e. this check will lead
to the wrong result.
--
To view, visit http://gerrit.ovirt.org/5067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15208fadf9a84dfe55b3b896ed44c37ac3f3c7fc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
