Omer Frenkel has posted comments on this change. Change subject: core: cleanup in pool related commands ......................................................................
Patch Set 3: Code-Review+1 (1 comment) not sure about the change in quota-consumption-params, dont know how it is used http://gerrit.ovirt.org/#/c/26362/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java: Line 39: } Line 40: Line 41: @Override Line 42: protected boolean canDoAction() { Line 43: if (!super.canDoAction()){ missing space here before '{' Line 44: return false; Line 45: } Line 46: Line 47: if (VmTemplateHandler.BLANK_VM_TEMPLATE_ID.equals(getParameters().getVmStaticData().getVmtGuid())) { -- To view, visit http://gerrit.ovirt.org/26362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2a2f9a35a676ea7a7f9fe015794716e42ca41dc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
