Eli Mesika has posted comments on this change. Change subject: jsonrpc: Stomp changes in vdsbroker ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/26783/2//COMMIT_MSG Commit Message: Line 10: columnt columnt=>column Line 13: amqp which probably will be 2. Line 14: Line 15: Bug-Url: https://bugzilla.redhat.com/1081049 Line 16: Change-Id: If78de6620ba6891543531ac8ddd633b67828a89c Line 17: Signed-off-by: pkliczewski <[email protected]> I think that you should add this column to the fixtures.xml as well http://gerrit.ovirt.org/#/c/26783/2/packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql File packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql: Line 55: 'vds_group_compatibility_version', 'vds_group_virt_service', 'vds_group_gluster_service', 'host_os', 'kvm_version', 'libvirt_version', 'spice_version', 'kernel_version', Line 56: 'iscsi_initiator_name', 'transparent_hugepages_state', 'anonymous_hugepages', Line 57: 'non_operational_reason', 'recoverable', 'sshkeyfingerprint', 'count_threads_as_cores', 'cpu_threads', Line 58: 'hw_manufacturer', 'hw_product_name', 'hw_version', 'hw_serial_number', 'hw_uuid', 'hw_family', 'ssh_port', 'ssh_username', 'boot_time', Line 59: 'pm_detect_kdump', 'protocol')); Please do that with fn_db_add_column_to_object_white_list(obj,col) as described below in the comment Line 60: -- pm_options are missing Line 61: END; $function$ Line 62: LANGUAGE plpgsql; Line 63: SELECT * FROM __temp_add_object_column_white_list_table(); -- To view, visit http://gerrit.ovirt.org/26783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If78de6620ba6891543531ac8ddd633b67828a89c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
