Juan Hernandez has posted comments on this change. Change subject: restapi: NUMA feature restful API support ......................................................................
Patch Set 2: (6 comments) I miss the tests for the new resources. http://gerrit.ovirt.org/#/c/26943/2/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmNumaNodeResource.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmNumaNodeResource.java: Line 6: Line 7: import org.jboss.resteasy.annotations.providers.jaxb.Formatted; Line 8: import org.ovirt.engine.api.model.VirtualNumaNode; Line 9: Line 10: public interface VmNumaNodeResource extends DeviceResource<VirtualNumaNode> { You should add the following annotation to this class: @Produces({ApiMediaType.APPLICATION_XML, ApiMediaType.APPLICATION_JSON, ApiMediaType.APPLICATION_X_Y AML}) Otherwise RESTEasy will use the default content type "text/html" and there are no mechanism to translate a VirtualNumaNode into HTML. Line 11: Line 12: @PUT Line 13: @Formatted Line 14: @Override http://gerrit.ovirt.org/#/c/26943/2/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 4132: <xs:complexContent> Line 4133: <xs:extension base="BaseResource"> Line 4134: <xs:sequence> Line 4135: <xs:element ref="host" minOccurs="0" maxOccurs="1"/> Line 4136: <xs:element name="index" type="xs:int" minOccurs="0"/> Please be explicit with "maxOccurs". Line 4137: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4138: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4139: <xs:element name="statistics" type="Statistics" minOccurs="0" maxOccurs="1"/> Line 4140: <xs:element name="node_distance" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4134: <xs:sequence> Line 4135: <xs:element ref="host" minOccurs="0" maxOccurs="1"/> Line 4136: <xs:element name="index" type="xs:int" minOccurs="0"/> Line 4137: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4138: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> What will be the format of this list? Line 4139: <xs:element name="statistics" type="Statistics" minOccurs="0" maxOccurs="1"/> Line 4140: <xs:element name="node_distance" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4141: </xs:sequence> Line 4142: </xs:extension> Line 4136: <xs:element name="index" type="xs:int" minOccurs="0"/> Line 4137: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4138: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4139: <xs:element name="statistics" type="Statistics" minOccurs="0" maxOccurs="1"/> Line 4140: <xs:element name="node_distance" type="xs:string" minOccurs="0" maxOccurs="1"/> And the format of this? Line 4141: </xs:sequence> Line 4142: </xs:extension> Line 4143: </xs:complexContent> Line 4144: </xs:complexType> Line 4163: <xs:complexContent> Line 4164: <xs:extension base="BaseDevice"> Line 4165: <xs:sequence> Line 4166: <xs:element ref="host" minOccurs="0" maxOccurs="1"/> Line 4167: <xs:element name="index" type="xs:int" minOccurs="0"/> Please, be explicit with "maxOccurs". Line 4168: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4169: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4170: <xs:element name="pin_host_node_list" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4171: </xs:sequence> Line 4165: <xs:sequence> Line 4166: <xs:element ref="host" minOccurs="0" maxOccurs="1"/> Line 4167: <xs:element name="index" type="xs:int" minOccurs="0"/> Line 4168: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4169: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> What is the format of this list? Line 4170: <xs:element name="pin_host_node_list" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4171: </xs:sequence> Line 4172: </xs:extension> Line 4173: </xs:complexContent> -- To view, visit http://gerrit.ovirt.org/26943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72ed4b16c220decbf640f74c4aadffe423afc290 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
