Yair Zaslavsky has posted comments on this change. Change subject: aaa: extension-manager: support javascript extensions ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/27281/1/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java: Line 45: * Extension binding method. Line 46: * Bindings method to use. Line 47: * <ul> Line 48: * <li>{@link ConfigBindingsMethods#JBOSSMODULE}</li> Line 49: * <li>{@link ConfigBindingsMethods#SCRIPTENGINE}</li> 1. And I was about to ask what is the next binding method - script engine is cool! 2. see previous comments on how to arrange the keys. Line 50: * </ul> Line 51: * Mandatory if binding method is Jboss module. Line 52: * @see ConfigBindingsMethods Line 53: */ http://gerrit.ovirt.org/#/c/27281/1/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 105: props.getProperty(Base.ConfigKeys.BINDINGS_SCRIPTENGINE_SCRIPT)); Line 106: Reader reader = new InputStreamReader(in); Line 107: ) { Line 108: ScriptEngine engine = new ScriptEngineManager().getEngineByName( Line 109: props.getProperty(Base.ConfigKeys.BINDINGS_SCRIPTENGINE_ENGINE)); see my previous comment n the namespace, for example - maybe Base.ConfigKeys.Bindingins.SciprtEngine.ENGINE ? Line 110: if (engine == null) { Line 111: throw new ConfigurationException(String.format("Script engine '%1$s' cannot be loaded.", Line 112: props.getProperty(Base.ConfigKeys.BINDINGS_SCRIPTENGINE_ENGINE))); Line 113: } -- To view, visit http://gerrit.ovirt.org/27281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d9dee411f5b0bf5019a35810f5f43b53ca3f3ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
