Yair Zaslavsky has posted comments on this change. Change subject: [WIP] core: introduce AsyncTaskStrategy ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26912/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskStrategyType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskStrategyType.java: Line 10: public static AsyncTaskStrategyType forValue(int value) { Line 11: return values()[value]; Line 12: } Line 13: Line 14: public boolean isSPMStrategy() { i thought that one of the reasonsof having strategy is so we would not have to check "isSPMTask" or "isSPMStrategy".... if you have SPM specific code, shouldn't it exist at the SPM strategy? if you need to add more methods to implement it - feel free, and add these methods at the strategy interface, and for non SPM strategy, have blank implementations. Line 15: return (this == SPMTaskStrategy); Line 16: } -- To view, visit http://gerrit.ovirt.org/26912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460b98c3d4b38243da61433d08c16f1cde5b9e17 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
