Omer Frenkel has posted comments on this change. Change subject: core: sysprep timezone is set as system timezone ......................................................................
Patch Set 3: (1 comment) looks ok minor comment http://gerrit.ovirt.org/#/c/27260/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java: Line 179: } Line 180: Line 181: if (osRepository.isTimezoneValueInteger(vm.getStaticData(). getOsId(), null)) { Line 182: // send correct time zone as sysprep expect to get it (a wierd number) Line 183: retVal = getTimezoneIndexByKey(timeZone); i think you could use only the timezone variable, set it inside the if here, and nothing to do in the else Line 184: } else { Line 185: retVal = timeZone; Line 186: } Line 187: -- To view, visit http://gerrit.ovirt.org/27260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If48c49b7e36d5382965a77c99fd7fa1f5d884578 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
