Yevgeny Zaspitsky has uploaded a new change for review. Change subject: webadmin: Add warning about changing display network in Edit Network screen ......................................................................
webadmin: Add warning about changing display network in Edit Network screen Change-Id: I076156d70869dcd682ab742660d6271ee398f509 Bug-Url: https://bugzilla.redhat.com/1078836 Signed-off-by: Yevgeny Zaspitsky <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java 3 files changed, 24 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/27301/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java index c2b5fc3..e123b8b 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java @@ -130,6 +130,10 @@ @UiField @Ignore + Label displayNetworkChangeWarning; + + @UiField + @Ignore DockLayoutPanel layoutPanel; @UiField @@ -282,6 +286,7 @@ isToSync.setVisible(false); isToSyncInfo.setVisible(false); + displayNetworkChangeWarning.setVisible(false); } protected void enableDisableBySync(HostInterfaceModel model) { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml index 087f27e..5f541ea 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml @@ -24,6 +24,12 @@ .customPropertiesStyle { max-height: 100px; } + + .displayNetworkChangeWarning { + color: red; + font-weight: bold; + text-align: center; + } </ui:style> <d:SimpleDialogPanel width="400px" height="500px"> @@ -53,6 +59,7 @@ <ge:EntityModelCheckBoxEditor ui:field="isToSync" /> <d:InfoIcon ui:field="isToSyncInfo"/> </g:HorizontalPanel> + <g:Label ui:field="displayNetworkChangeWarning" addStyleNames="{style.displayNetworkChangeWarning}" /> <ge:EntityModelCheckBoxEditor ui:field="checkConnectivity" /> <g:Label ui:field="message" /> </g:VerticalPanel> diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java index 7377ed4..11ec642 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java @@ -9,7 +9,10 @@ import com.google.gwt.event.shared.EventBus; import com.google.inject.Inject; -public class SetupNetworksInterfacePopupView extends HostInterfacePopupView implements SetupNetworksInterfacePopupPresenterWidget.ViewDef { +public class SetupNetworksInterfacePopupView extends HostInterfacePopupView + implements SetupNetworksInterfacePopupPresenterWidget.ViewDef { + + private final ApplicationConstants constants; @Inject public SetupNetworksInterfacePopupView(EventBus eventBus, @@ -18,6 +21,8 @@ ApplicationTemplates templates) { super(eventBus, resources, constants, templates); + + this.constants = constants; } @Override @@ -31,7 +36,7 @@ commitChanges.setVisible(false); isToSync.setVisible(true); - if (object.getIsToSync().getIsChangable()){ + if (object.getIsToSync().getIsChangable()) { isToSyncInfo.setVisible(true); } @@ -44,5 +49,10 @@ customPropertiesPanel.setVisible(object.getCustomPropertiesModel().getIsAvailable()); customPropertiesWidget.edit(object.getCustomPropertiesModel()); + + if (object.getNetwork().getSelectedItem().getCluster().isDisplay()) { + displayNetworkChangeWarning.setText(constants.changeDisplayNetworkWarning()); + displayNetworkChangeWarning.setVisible(true); + } } } -- To view, visit http://gerrit.ovirt.org/27301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I076156d70869dcd682ab742660d6271ee398f509 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
