Eli Mesika has posted comments on this change. Change subject: engine: adding base_interface column to vds_interface table ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/26605/7//COMMIT_MSG Commit Message: Line 7: engine: adding base_interface column to vds_interface table Line 8: Line 9: We should accept vlan devices identified by any name (and not only Line 10: baseIface.vlanId) Line 11: Therefore the baseInterface name cannot longer be detrmined from the detrmined=>determined Line 12: vlan device name. Line 13: If the interface is vlan the colums will contain the base interface Line 14: name. Line 15: Line 9: We should accept vlan devices identified by any name (and not only Line 10: baseIface.vlanId) Line 11: Therefore the baseInterface name cannot longer be detrmined from the Line 12: vlan device name. Line 13: If the interface is vlan the colums will contain the base interface colums=>columns Line 14: name. Line 15: Line 16: Change-Id: I87ac5121b9e7d3b74f5557336e5d504ef91b7702 Line 17: Bug-Url: https://bugzilla.redhat.com/1091863 http://gerrit.ovirt.org/#/c/26605/7/packaging/dbscripts/upgrade/03_05_0370_add_base_interface_column_to_vds_interfaces.sql File packaging/dbscripts/upgrade/03_05_0370_add_base_interface_column_to_vds_interfaces.sql: Line 1: select fn_db_add_column('vds_interface', 'base_interface', 'varchar(50)'); Line 2: update vds_interface set base_interface = substring(name from '(.*)\.[^\.]*') where vlan_id is not NULL; Can you please add an example of how this changes the data -- To view, visit http://gerrit.ovirt.org/26605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ac5121b9e7d3b74f5557336e5d504ef91b7702 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
