Alon Bar-Lev has posted comments on this change. Change subject: tools: static inner class ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27311/1/backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilterTest.java File backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilterTest.java: Line 23: /* Line 24: * This replaces the application message representation, the only request we have is to have getName() to return the Line 25: * name based on which we filter. Line 26: */ Line 27: static class E extends AuditLogEvent { > the visibility could be reduced to private if not used elsewhere and to imp Done Line 28: private String e; Line 29: Line 30: public E(String e) { Line 31: this.e = e; -- To view, visit http://gerrit.ovirt.org/27311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77d60446317c5a8a53c50b136b4c1040f8ba59b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
