Tal Nisan has posted comments on this change. Change subject: core: adding DAO support for unregistered VMs. ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/26480/3//COMMIT_MSG Commit Message: Line 7: core: adding DAO support for unregistered VMs. Line 8: Line 9: * Add new BE OvfEntityData Line 10: * Adding new table unregistered_ovf_of_entities Line 11: * Add stored procedured s/procedured/procedures Line 12: * Adding UnregisteredOVFDataDAO Line 13: Line 14: Change-Id: I385fac757f46131ae0c0048b6cf39b78f037e852 http://gerrit.ovirt.org/#/c/26480/3/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 1457: <column>ovf_data</column> Line 1458: <column>ovf_extra_data</column> Line 1459: <column>os_id</column> Line 1460: <column>lowest_comp_version</column> Line 1461: <row> I'd put at least another entity here, testing 'get' entity is quite pointless if you only have one entity in the DB Line 1462: <value>77296e00-0cad-4e5a-9299-008a7b6f4354</value> Line 1463: <value>rhel5-pool-50</value> Line 1464: <value>VM</value> Line 1465: <value>d9ede37f-e6c3-4bf9-a984-19174070aa31</value> http://gerrit.ovirt.org/#/c/26480/3/packaging/dbscripts/upgrade/03_05_0330_unregistered_ovf_of_entities.sql File packaging/dbscripts/upgrade/03_05_0330_unregistered_ovf_of_entities.sql: Line 2: ( Line 3: vm_guid UUID PRIMARY KEY, Line 4: vm_name character varying(255) NOT NULL, Line 5: entity_type character varying(32) NOT NULL, Line 6: storage_domain_id UUID, The storage domain should exist in the DB? If so you should probably use a constraint here Line 7: ovf_data text, Line 8: ovf_extra_data text, Line 9: os_id integer, Line 10: lowest_comp_version character varying(40) -- To view, visit http://gerrit.ovirt.org/26480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I385fac757f46131ae0c0048b6cf39b78f037e852 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
