Yaniv Dary has posted comments on this change. Change subject: reports: br14 report - added comments to queries ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/26348/5/packaging/ovirt-reports/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/br14_table.jrxml.data File packaging/ovirt-reports/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/br14_table.jrxml.data: Line 119: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '3 month' Line 120: WHEN $P{P_Period} = 3 Line 121: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 year' Line 122: END Line 123: AND v3_4_configuration_history_vms.history_id IN ( This should be indented with one less tab. Line 124: SELECT MAX ( a.history_id ) Line 125: FROM v3_4_configuration_history_vms a Line 126: GROUP BY a.vm_id Line 127: ) http://gerrit.ovirt.org/#/c/26348/5/packaging/ovirt-reports/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/virtual_servers_uptime_br14_jrxml.data File packaging/ovirt-reports/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/virtual_servers_uptime_br14_jrxml.data: Line 59: WHEN stats_vms.vm_status = 1 Line 60: THEN COALESCE ( Line 61: stats_vms.minutes_in_status, Line 62: 0 Line 63: ) This should be indented with one more tab Line 64: ELSE 0 Line 65: END Line 66: ) AS uptime_mins, Line 67: SUM ( -- To view, visit http://gerrit.ovirt.org/26348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76efaad98171ad2bcf05bbf8acb3a2306aee88c6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
