Arik Hadas has posted comments on this change. Change subject: core: add Venezuela time zone ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/27250/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java: Line 177: windowsTimeZones.put("Dateline Standard Time", "(GMT-12:00) Dateline Standard Time"); Line 178: windowsTimeZones.put("SA Pacific Standard Time", "(GMT-05:00) SA Pacific Standard Time"); Line 179: windowsTimeZones.put("West Pacific Standard Time", "(GMT+10:00) West Pacific Standard Time"); Line 180: windowsTimeZones.put("N. Central Asia Standard Time", "(GMT+06:00) N. Central Asia Standard Time"); Line 181: windowsTimeZones.put("Venezuela Standard Time", "(GMT-04:30) Venezuela Standard Time"); > so what about the mapping to int (old windows sysprep value) I put needinfo in bz for that - if we'll decide not to show that for OSs with old windows sysprep, then we don't need the mapping. it is confusing as it seems like this patch is ready to be merged because of the verified flag, so I'll set the code review flag to -1 in the meantime Line 182: Line 183: return sortMapByValue(windowsTimeZones); Line 184: } Line 185: }; -- To view, visit http://gerrit.ovirt.org/27250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia536ba0adc91b371be695dff4b15fd47d7c784f9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
