Martin Peřina has posted comments on this change.

Change subject: [RFE] Add periodic power management health check..
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27367/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java:

Line 54:     public void pmHealthCheck() {
Line 55:         // skip PM health check if previous operation is not complete 
yet
Line 56:         if (!inWork) {
Line 57:             synchronized (instance) {
Line 58:                 List<VDS> hosts = 
DbFacade.getInstance().getVdsDao().getAll();
> StatefullJob is Deprecated 
Thx, I missed that. It looks like new method is to annotate job instance:

http://www.quartz-scheduler.org/api/2.0.0/org/quartz/DisallowConcurrentExecution.html
Line 59:                 for (VDS host : hosts) {
Line 60:                     if (host.getpm_enabled()) {
Line 61:                         boolean hasSecondary = 
(host.getPmSecondaryIp() != null && !host.getPmSecondaryIp().isEmpty());
Line 62:                         boolean isConcurrent = 
host.isPmSecondaryConcurrent();


-- 
To view, visit http://gerrit.ovirt.org/27367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1dfeab92a35793ebb421db8e3be94587dfe85e2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to