Simone Tiraboschi has posted comments on this change. Change subject: storage: detect localfs storage ......................................................................
Patch Set 1: Verified+1 Code-Review+1 (1 comment) Looks good to me, but someone else must approve http://gerrit.ovirt.org/#/c/27391/1/src/__main__.py File src/__main__.py: Line 1068: logging.error( Line 1069: _('Error message is "%s"'), Line 1070: str(e).strip() Line 1071: ) Line 1072: elif domain_type in ('localfs', ): > maybe here is better something like elif domain not nfs... but at the point you cannot simply state 'Upload to a *local* storage is'... Line 1073: ExitCodes.exit_code = ExitCodes.UPLOAD_ERR Line 1074: logging.error( Line 1075: _( Line 1076: 'Upload to a local storage domain is supported only ' -- To view, visit http://gerrit.ovirt.org/27391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff3313ba69500a7dbbdbe4c0972d747a9ae31b99 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
