Alon Bar-Lev has posted comments on this change. Change subject: backend: upgrade - process symbolic link files ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/27395/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java: Line 58 Line 59 Line 60 Line 61 Line 62 won't it better to have file.getCanonicalPath() http://gerrit.ovirt.org/#/c/27395/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java: Line 56: boolean ret = false; Line 57: Line 58: log.debugFormat("Check if ISO compatible: {0}", iso); Line 59: Line 60: String FileName = iso.getName(); same.... iso.getCanonicalPath() Line 61: Path path = Paths.get(iso.toString()); Line 62: try { Line 63: if (Files.isSymbolicLink(path)) { Line 64: FileName = Files.readSymbolicLink(path).getFileName().toString(); http://gerrit.ovirt.org/#/c/27395/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 787: select fn_db_update_config_value('MigrationSupportForNativeUsb','false','3.0'); Line 788: select fn_db_update_config_value('MigrationSupportForNativeUsb','false','3.1'); Line 789: select fn_db_update_config_value('MinimalETLVersion','3.4.0','general'); Line 790: select fn_db_update_config_value('OvirtInitialSupportedIsoVersion','2.5.5:5.8','general'); Line 791: select fn_db_update_config_value('OvirtIsoPrefix','^ovirt-node-iso-(.*)\.*\.iso$:^rhevh-(.*)\.*\.iso$','general'); is it a must? why not leave it? Line 792: select fn_db_update_config_value('OvirtNodeOS','^ovirt.*$:^rhev.*$','general'); Line 793: select fn_db_update_config_value('oVirtISOsRepositoryPath','/usr/share/ovirt-node-iso:/usr/share/rhev-hypervisor','general'); Line 794: select fn_db_update_config_value('PostgresPagingSyntax','OFFSET (%1$s -1) LIMIT %2$s','general'); Line 795: select fn_db_update_config_value('PostgresSearchTemplate','SELECT * FROM (%2$s) %1$s) as T1 %3$s','general'); -- To view, visit http://gerrit.ovirt.org/27395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4084095c40848dc5573d434c1c7ca497883b280 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
