Sandro Bonazzola has posted comments on this change. Change subject: Removing useless info line on specific excpetion ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/27413/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-05-06 14:56:45 +0200 Line 4: Commit: Simone Tiraboschi <[email protected]> Line 5: CommitDate: 2014-05-06 15:12:08 +0200 Line 6: Line 7: Removing useless info line on specific excpetion excpetion -> exception Line 8: Line 9: On an exception it always says Line 10: INFO: Use the -h option to see usage. Line 11: but this is not always usefull http://gerrit.ovirt.org/#/c/27413/3/src/__main__.py File src/__main__.py: Line 441: class NEISODomain(RuntimeError): Line 442: """" Line 443: This exception is raised when the user inputs a not existing ISO domain Line 444: """ Line 445: pass No reason for using inner classes, please move in global scope Line 446: Line 447: def __init__(self, conf): Line 448: self.api = None Line 449: self.configuration = conf -- To view, visit http://gerrit.ovirt.org/27413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4ff43555cb8105e27a83ef8dff5b7df42038ae1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
