Allon Mureinik has posted comments on this change. Change subject: core: Permission filtering for 'GetRoleById' Query. ......................................................................
Patch Set 1: Looks good to me, but someone else must approve perhaps you should change the name of the patch to something like "Make GetRoleByIdQuery available to non-admin users" or something like that (since you don't do any permission filtering here), but other than that - +1. -- To view, visit http://gerrit.ovirt.org/5132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb0a7e15ca01b03c9ea25a9af107eb71ecb85012 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
