Dima Kuznetsov has posted comments on this change. Change subject: core: Add selinux host info to VdsDynamic ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/26955/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 52: import java.util.Map; Line 53: import java.util.concurrent.ConcurrentHashMap; Line 54: import java.util.concurrent.TimeUnit; Line 55: import java.util.concurrent.atomic.AtomicBoolean; Line 56: import java.util.concurrent.atomic.AtomicInteger; IntelliJ did this, will change back. Line 57: Line 58: public class VdsManager { Line 59: private VDS _vds; Line 60: private long lastUpdate; http://gerrit.ovirt.org/#/c/26955/5/packaging/dbscripts/upgrade/03_05_0350_add_selinux_to_vds_dynamic.sql File packaging/dbscripts/upgrade/03_05_0350_add_selinux_to_vds_dynamic.sql: Line 1: select fn_db_add_column('vds_dynamic', 'selinux_enforce_mode', 'INTEGER'); > no default ? is that OK that this will be null or we prefer a default numbe I am ok with having null, it means that info is n/a. http://gerrit.ovirt.org/#/c/26955/5/packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql File packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql: Line 55: 'vds_group_compatibility_version', 'vds_group_virt_service', 'vds_group_gluster_service', 'host_os', 'kvm_version', 'libvirt_version', 'spice_version', 'kernel_version', Line 56: 'iscsi_initiator_name', 'transparent_hugepages_state', 'anonymous_hugepages', Line 57: 'non_operational_reason', 'recoverable', 'sshkeyfingerprint', 'count_threads_as_cores', 'cpu_threads', Line 58: 'hw_manufacturer', 'hw_product_name', 'hw_version', 'hw_serial_number', 'hw_uuid', 'hw_family', 'ssh_port', 'ssh_username', 'boot_time', Line 59: 'pm_detect_kdump', 'selinux_enforce_mode')); > Should be done with the function below , I will check and verify that this I was not able to get it to work, for the following reason: fn_db_add_column_to_object_white_list (common_sp.sql) inserts into table object_column_white_list (created in post_upgrade/0010_add_object_column_white_list_table.sql) but (to my best understanding) the post script is run after all the upgrade scripts are done. I case post_upgrade was never run before (empty DB), there is no object_column_white_list table while upgrades run. Line 60: -- pm_options are missing Line 61: END; $function$ Line 62: LANGUAGE plpgsql; Line 63: SELECT * FROM __temp_add_object_column_white_list_table(); -- To view, visit http://gerrit.ovirt.org/26955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If472f68702b59280c721450d4db50dc27dc19a30 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
