Yair Zaslavsky has posted comments on this change. Change subject: core: Improve classpath building ......................................................................
Patch Set 1: (2 inline comments) .................................................... File packaging/fedora/engine-java.py Line 33: "commons-codec": "/usr/share/java/commons-codec-eap6/commons-codec.jar", Maybe I didn't fully understand - I think we should have here like two definitions of sets of jar (this is the "partition" - one of jars shipped with RHEL , and one which is like engine-specific. But I feel that both should probably be aliased , as I wrote. I see no reason why not to provide the exact versions (i.e - I'm thinking for example about our poms , where we specify the versions of the artifacts). Line 168: def resolveExactJar(name, path): Ok, thanks for the info. -- To view, visit http://gerrit.ovirt.org/5129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eed7495f8d380656ef413596d7848618e395c96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
