Gilad Chaplik has posted comments on this change. Change subject: webadmin: Password field is not validate on host install ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27324/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java: Line 1326: final boolean isOVirt = host.getVdsType() == VDSType.oVirtNode; Line 1327: Line 1328: if (!model.validate(isOVirt)) Line 1329: { Line 1330: model.setTabToSelect(new EntityModel<Integer>(0)); > A call to model.setTabToSelect raised an event SELECT_TAB, HostInstallPopup 'tab' is a widget, and a part of a view, use better terminology like: 'validation failed' or sth. Line 1331: return; Line 1332: } Line 1333: Line 1334: UpdateVdsActionParameters param = new UpdateVdsActionParameters(); -- To view, visit http://gerrit.ovirt.org/27324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3745852a0b1b33e5ba04583e911bbbc90fd8d796 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
