Sandro Bonazzola has posted comments on this change. Change subject: Making engine configuration optional during engine-setup ......................................................................
Patch Set 1: > this patch should move all engine specific variables into own file at one > place. I don't agree. constants are in public API in /usr/lib/python.... and I don't think we should move them at once without proper deprecation. > sandro, can you please take care of explaining what needed to do... I do not > have much time for this ping-pong. Do you want a single patch with full refactoring at once, including deprecation of existing API? -- To view, visit http://gerrit.ovirt.org/27512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0302fecf98024adc3a7c796bf762a2009108760 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
