Gilad Chaplik has posted comments on this change. Change subject: db: Numa support database implementation ......................................................................
Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/26996/15/packaging/dbscripts/upgrade/03_05_0330_add_numa_tables_and_columns.sql File packaging/dbscripts/upgrade/03_05_0330_add_numa_tables_and_columns.sql: Line 5: -- Numa nodes table Line 6: CREATE TABLE numa_node Line 7: ( Line 8: numa_node_id UUID NOT NULL, Line 9: vm_or_vds_guid UUID NOT NULL, > 2 columns are ok. This solution is simple. I agree. worth exploring if have time in the future. Line 10: numa_node_index INTEGER, Line 11: mem_total BIGINT, Line 12: cpu_count INTEGER, Line 13: mem_free BIGINT, Line 45: id UUID NOT NULL, Line 46: vm_numa_node_id UUID NOT NULL, Line 47: vds_numa_node_id UUID NOT NULL, Line 48: CONSTRAINT pk_vm_vds_numa_node_map PRIMARY KEY(id), Line 49: CONSTRAINT fk_vm_vds_numa_node_map_vds_numa_node FOREIGN KEY(vds_numa_node_id) REFERENCES numa_node(numa_node_id) ON DELETE CASCADE, > This fk is on vds_numa_node_id. That means if a host is deleted, all the pn I will try to explain: if a vm is down and "numa pinned" to a certain host, removing the host will result in deleting the pinning. means the vm has no pinning. in cases when the hosts cluster will have the same numa topology, I'd like to have preserve the pinning for other hosts also when a host, that has numa pinning, has been deleted, simply with other pnuma node uuid. in order to fully fulfil that: 1) '... ON DELETE CASCADE,' should be '... ON DELETE SET NULL,' 2) adding pnuma node index filed. Line 50: CONSTRAINT fk_vm_vds_numa_node_map_vm_numa_node FOREIGN KEY(vm_numa_node_id) REFERENCES numa_node(numa_node_id) ON DELETE CASCADE Line 51: ); Line 52: Line 53: -- Create partial index for numa node map -- To view, visit http://gerrit.ovirt.org/26996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2507c084aa214bcfb65e860b11ed7dcf02af50cc Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jason Liao <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
