Lior Vernia has posted comments on this change. Change subject: webadmin: Warn user if KeystoneAuthUrl wasn't configured ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27517/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java: Line 419: if (result == null || !result.getSucceeded()) { Line 420: if ((Boolean) requiresAuthentication.getEntity() && StringHelper.isNullOrEmpty(keystoneUrl)) { Line 421: errorMessage = ConstantsManager.getInstance().getConstants().noAuthUrl(); Line 422: } else if (result != null) { Line 423: errorMessage = Frontend.getInstance().translateVdcFault(result.getFault()); > What if result.getFault() is null? getFault() seems to never return null - if fault is null then a new default fault is created in the getter. Line 424: } else { Line 425: errorMessage = ConstantsManager.getInstance().getConstants().testFailedUnknownErrorMsg(); Line 426: } Line 427: } -- To view, visit http://gerrit.ovirt.org/27517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c0a8586b4845efbee0d599b31d92ce8158d336 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
