Yaniv Dary has posted comments on this change. Change subject: packaging: setup: Force a minimal ETL version ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27524/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py: Line 73: minVersion, minMinor = self._parseVersionString(minimalVersion) Line 74: curVersion, curMinor = self._parseVersionString(currentVersion) Line 75: if ( Line 76: (float(curVersion) != float(minVersion)) or Line 77: (int(curMinor) < int(minMinor)) This not the correct if. It's of the major version is not the same or it is the same and minor is smaller or then the etl self. Also will this work in install-dev? Line 78: ): Line 79: raise RuntimeError( Line 80: _( Line 81: 'Minimal supported DWH version ({minimal}) is ' -- To view, visit http://gerrit.ovirt.org/27524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccef80d1397c6b66ad5a8440e59af238b42416a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
