Yaniv Dary has posted comments on this change. Change subject: history: Updated calculation of cpu usage ......................................................................
Patch Set 1: (2 comments) Also change minimal ETL version in 000_config to 3.4.1 http://gerrit.ovirt.org/#/c/27559/1/packaging/dbscripts/create_dwh_views.sql File packaging/dbscripts/create_dwh_views.sql: Line 272: cast( Line 273: c.cpu_sys / Line 274: (vm_static.cpu_per_socket * vm_static.num_of_sockets) Line 275: as smallint Line 276: ) This is not indented correctly Line 277: as system_cpu_usage_percent, Line 278: cast( Line 279: c.cpu_user / Line 280: (vm_static.cpu_per_socket * vm_static.num_of_sockets) Line 290: WHEN b.guest_cur_user_name IS NULL THEN FALSE Line 291: ELSE TRUE Line 292: END as user_logged_in_to_guest, Line 293: b.run_on_vds as currently_running_on_host Line 294: FROM vm_dynamic b, vm_statistics c, vm_static please add ON clauses and add login to them. Line 295: WHERE Line 296: c.vm_guid = b.vm_guid Line 297: AND c.vm_guid = vm_static.vm_guid; Line 298: -- To view, visit http://gerrit.ovirt.org/27559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfae05895d8450e6d5f450fbf2a9e934e65a5785 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
