Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Update postgresql.conf listen_address ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27285/2/packaging/setup/ovirt_engine_setup/postgres.py File packaging/setup/ovirt_engine_setup/postgres.py: Line 285: if ( Line 286: maxConnOK is False or Line 287: listenAddrOK is False Line 288: ): Line 289: break > Please avoid to use "is False" and "is True". Wrote a long comment about the various options, then changed the code instead. Do you prefer it this way? I think I do not, do not mind much. If you want something else say exactly what you want. Line 290: if (maxConnOK is True and listenAddrOK is True): Line 291: needUpdate = False Line 292: break Line 293: -- To view, visit http://gerrit.ovirt.org/27285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e2111271732f395878621b23b9ca3689814a084 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
