Alon Bar-Lev has posted comments on this change. Change subject: fklsnr: Introduce standalone fence_kdump listener ......................................................................
Patch Set 6: Missed this, as I want dao to be finished first. > In case the DB is slow we may miss packets. If DB is slow and application is fast, and you use queue, eventually you get memory loaded anyway. One solution can be to update database at interval per all sessions and not at each packet received, at least this will be O(1), but the dao layer is still incomplete for this suggestion. In most cases the system buffers should compensate on reasonable delay. And in this specific case, let's discuss: 1. we miss start dump but we get "dumping", so we assume dumping. 2. we miss dumping message, so we get other. 3. we miss end of dumping (assuming there was) so we assume end after timeout. So our application is not sensitive for package loss even significant one, so there is no reason to introduce complexity. > what happens when DB connection get lost? I will send you offline thread regarding that. -- To view, visit http://gerrit.ovirt.org/27201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
