Daniel Erez has posted comments on this change. Change subject: core: adding SetVolumeDescriptionVDSCommand ......................................................................
Patch Set 1: (2 comments) a couple of minor comments http://gerrit.ovirt.org/#/c/26672/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-04-06 10:18:15 +0300 Line 4: Commit: Liron Aravot <[email protected]> Line 5: CommitDate: 2014-04-10 15:30:29 +0300 Line 6: Line 7: core: adding SetVolumeDescriptionVDSCommand Can you please explain the necessity of the command Line 8: Line 9: Change-Id: I36b68ca2d996cf151efc267bceee354e0df223f1 http://gerrit.ovirt.org/#/c/26672/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SetVolumeDescriptionVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SetVolumeDescriptionVDSCommand.java: Line 25: getParameters().getImageGroupId().toString(), Line 26: getParameters().getImageId().toString(), Line 27: getParameters().getDescription()); Line 28: Line 29: getIrsProxy().setVolumeDescription( no need to use return value/status/etc? Line 30: getParameters().getStoragePoolId().toString(), Line 31: getParameters().getStorageDomainId().toString(), Line 32: getParameters().getImageGroupId().toString(), Line 33: getParameters().getImageId().toString(), -- To view, visit http://gerrit.ovirt.org/26672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36b68ca2d996cf151efc267bceee354e0df223f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
