Oved Ourfali has posted comments on this change.

Change subject: engine : Tunnel calls to AsyncTaskManager and introduce CoCo
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/26332/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java:

Line 416:     }
Line 417: 
Line 418:     @Override
Line 419:     public void taskEndSuccessfully() {
Line 420:         // Not implemented
do we need to also throw a NonimplementedException here?
Line 421:     }
Line 422: 
Line 423:     public void preventRollback() {
Line 424:         throw new NotImplementedException();


-- 
To view, visit http://gerrit.ovirt.org/26332
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic075b65ebc2dcd067c3fe514fe03dbb719b54e94
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to