Omer Frenkel has posted comments on this change. Change subject: engine: Skipping Cluster CPU validation in GlusterOnly mode ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java Line 111: } else if (appMode != ApplicationMode.GlusterOnly why not use supportsGlusterService ? basically the appMode config is UI config and not used in the engine, so im not sure i like start using it without thinking it thruogh. -- To view, visit http://gerrit.ovirt.org/5165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45b1019bd28c0b48e0fd277437bec260d5a06b84 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
