Yair Zaslavsky has posted comments on this change. Change subject: aaa: fix coverity issues ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27397/2/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java: Line 126: + " Failed to query rootDSE in order to get the baseDN. Could not query for user " Line 127: + userName + " in domain " + domainName); Line 128: } Line 129: } finally { Line 130: if (ctx != null) { > and remove condition? see previous answer. Line 131: ctx.close(); Line 132: } Line 133: } Line 134: } catch (CommunicationException ex) { -- To view, visit http://gerrit.ovirt.org/27397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I057929e0f2dc7672bc5d06457d14c548f4726112 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
