Allon Mureinik has posted comments on this change. Change subject: core: cleanup of StorageHelperDirector ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperDirector.java Line 10: private static StorageHelperDirector _instance = new StorageHelperDirector(); Please remove the FQCNs here too. Also, _helpers can be defined as a Map instead of the concrete HashMap -- To view, visit http://gerrit.ovirt.org/5180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie667122156fce0c38312df7e08c22c599b59a900 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
