Lior Vernia has posted comments on this change. Change subject: webadmin: Add broker type to neutron agent configuration ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/27566/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 3186: Line 3187: @DefaultStringValue("Messaging Configuration") Line 3188: String messagingConfiguration(); Line 3189: Line 3190: @DefaultStringValue("Broker Type") Is "broker" the standard name for the implementation of the messaging server? If so, maybe the title of the section should be "Messaging Broker" or "Messaging Broker Configuration" instead of "Messaging Configuration". Otherwise, maybe this should be called "Server Type". Line 3191: String messagingBrokerType(); Line 3192: Line 3193: @DefaultStringValue("Host") Line 3194: String messagingServer(); http://gerrit.ovirt.org/#/c/27566/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/NeutronAgentWidget.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/NeutronAgentWidget.java: Line 76: Line 77: @UiField(provided = true) Line 78: @Path("brokerType.selectedItem") Line 79: @WithElementId("brokerType") Line 80: ListModelListBoxEditor<BrokerType> brokerTypeEditor; Please move the declaration according to the widget's location in the ui.xml file (i.e. above the server address). If I remember correctly the order of declaration determines the order in which the widgets are added to the dialog, which in turn determines the focus order of the widgets when clicking tab. Line 81: Line 82: @Inject Line 83: public NeutronAgentWidget() { Line 84: brokerTypeEditor = new ListModelListBoxEditor<BrokerType>(new EnumRenderer<BrokerType>()); -- To view, visit http://gerrit.ovirt.org/27566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04966edaebd4c9d260bbb42cae16ef3a42467ce3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
