Ravi Nori has posted comments on this change. Change subject: engine : Upgrading a hypervisor automatically puts it into an Up state ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27394/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java: Line 151: case Complete: Line 152: if (!configureNetworkUsingHostDeploy) { Line 153: configureManagementNetwork(); Line 154: } Line 155: if (VDSStatus.Maintenance.equals(vdsInitialStatus)) { > Isn't that better to put this code in VdsCommand instead of duplicating it There are lots of classes that extends VdsCommand. This is relevant only for Install and Upgrade Commands, please confirm that you would indeed like to put it in VdsCommand. Line 156: setVdsStatus(VDSStatus.Maintenance); Line 157: } else { Line 158: setVdsStatus(VDSStatus.Initializing); Line 159: } -- To view, visit http://gerrit.ovirt.org/27394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dbe7f492e7202b46f993d6ae3ac14714e39d768 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
