Liran Zelkha has posted comments on this change. Change subject: core: Support decreasing dc compatbility version ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/26947/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java: Line 191: // decreasing of compatibility version is not allowed Line 192: else if (getStoragePool().getcompatibility_version().compareTo(_oldStoragePool.getcompatibility_version()) < 0) { Line 193: // Enable to reduce compatibility version if DC has no hosts Line 194: Line 195: if (!getVdsDAO().getAllForStoragePool(getStoragePoolId()).isEmpty()) { > cut+paste from the latest reply on the E-mail: So, should we always allow for DC downgrade? What's the impact of this downgrade anyway? Line 196: returnValue = false; Line 197: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_DECREASE_COMPATIBILITY_VERSION); Line 198: } Line 199: if (returnValue) { -- To view, visit http://gerrit.ovirt.org/26947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bb99e4773ee5592483ad055b277641ebc63cae1 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
