Daniel Erez has posted comments on this change. Change subject: core: Detach storage domain when remove Storage Pool. ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/27307/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java: Line 322: if (!getParameters().getForceDelete()) { Line 323: if(poolDomains.size() > 1) { Line 324: return failCanDoAction(VdcBllMessages.ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_NONMASTER_DOMAINS); Line 325: } Line 326: if (!canDetachStorageDomainWithVmsAndDisks(poolDomains.get(0))) { Not directly related to this patch, but is problematic to extract it to StorageDomainValidator? Line 327: return false; Line 328: } Line 329: } else { Line 330: List<VDS> poolHosts = getVdsDAO().getAllForStoragePool(getParameters().getStoragePoolId()); -- To view, visit http://gerrit.ovirt.org/27307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I120c6b001a197e65528edb73375b379f76d24cd5 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
