Eli Mesika has posted comments on this change. Change subject: core: add 3.5 support ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/27613/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 237: select fn_db_add_config_value('SerialNumberPolicySupported','false','3.1'); Line 238: select fn_db_add_config_value('SerialNumberPolicySupported','false','3.2'); Line 239: select fn_db_add_config_value('SerialNumberPolicySupported','false','3.3'); Line 240: select fn_db_add_config_value('SerialNumberPolicySupported','false','3.4'); Line 241: select fn_db_add_config_value('SerialNumberPolicySupported','false','3.5'); > this is wrong, we set the config to false for old versions, and the default Done Line 242: Line 243: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.0'); Line 244: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.1'); Line 245: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.2'); Line 244: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.1'); Line 245: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.2'); Line 246: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.3'); Line 247: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.4'); Line 248: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.5'); > probably same, need someone from storage to comment Done Line 249: select fn_db_add_config_value('BootMenuSupported','false','3.0'); Line 250: select fn_db_add_config_value('BootMenuSupported','false','3.1'); Line 251: select fn_db_add_config_value('BootMenuSupported','false','3.2'); Line 252: select fn_db_add_config_value('BootMenuSupported','false','3.3'); Line 250: select fn_db_add_config_value('BootMenuSupported','false','3.1'); Line 251: select fn_db_add_config_value('BootMenuSupported','false','3.2'); Line 252: select fn_db_add_config_value('BootMenuSupported','false','3.3'); Line 253: select fn_db_add_config_value('BootMenuSupported','false','3.4'); Line 254: select fn_db_add_config_value('BootMenuSupported','false','3.5'); > same Done Line 255: Line 256: select fn_db_add_config_value('IscsiMultipathingSupported','false','3.0'); Line 257: select fn_db_add_config_value('IscsiMultipathingSupported','false','3.1'); Line 258: select fn_db_add_config_value('IscsiMultipathingSupported','false','3.2'); Line 646: select fn_db_add_config_value('NetworkCustomPropertiesSupported', 'false', '3.1'); Line 647: select fn_db_add_config_value('NetworkCustomPropertiesSupported', 'false', '3.2'); Line 648: select fn_db_add_config_value('NetworkCustomPropertiesSupported', 'false', '3.3'); Line 649: select fn_db_add_config_value('NetworkCustomPropertiesSupported', 'false', '3.4'); Line 650: select fn_db_add_config_value('NetworkCustomPropertiesSupported', 'false', '3.5'); > same? Done Line 651: select fn_db_add_config_value('PreDefinedNetworkCustomProperties', 'bridge_opts=^[^\s=]+=[^\s=]+(\s+[^\s=]+=[^\s=]+)*$', '3.5'); Line 652: select fn_db_add_config_value('UserDefinedNetworkCustomProperties', '', '3.5'); Line 653: Line 654: select fn_db_add_config_value('SshSoftFencingCommand', 'service vdsmd restart', '3.0'); -- To view, visit http://gerrit.ovirt.org/27613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0c3ce202789d983cae95b0b1ea4ef0ead73e0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
