Eli Mesika has posted comments on this change. Change subject: core: adding DAO support for unregistered VMs/Templates. ......................................................................
Patch Set 10: (5 comments) http://gerrit.ovirt.org/#/c/26480/10/packaging/dbscripts/unregistered_OVF_data_sp.sql File packaging/dbscripts/unregistered_OVF_data_sp.sql: Line 9: BEGIN Line 10: INSERT INTO unregistered_ovf_of_entities(vm_guid, storage_domain_id, entity_type, vm_name, os_id, lowest_comp_version, ovf_data, ovf_extra_data) Line 11: SELECT v_vm_guid, v_storage_domain_id, entity_type, vm_name, os, compatibility_version, ovf_data, v_ovf_extra_data Line 12: FROM vm_static vs,vm_ovf_generations vog,vds_groups Line 13: WHERE vs.vm_guid = vog.vm_guid This "where" should be in the BLL level , a where in the insert is not standard , please check first if you should insert and then the so should also do the job without any where clause Line 14: AND vs.vm_guid = v_vm_guid Line 15: AND vs.vds_group_id = vds_groups.vds_group_id; Line 16: END; $procedure$ Line 17: LANGUAGE plpgsql; Line 16: END; $procedure$ Line 17: LANGUAGE plpgsql; Line 18: Line 19: Line 20: Create or replace FUNCTION removeEntityFromUnregistered(v_vm_guid UUID, v_storage_domain_id UUID) =>RemoveEntityFromUnregistered Line 21: RETURNS VOID Line 22: AS $procedure$ Line 23: DECLARE Line 24: v_val UUID; Line 33: getAllOVFEntitiesForStorageDomain =>GetAllOVFEntitiesForStorageDomain Line 45: getOVFDataByVmId =>GetOVFDataByVmId http://gerrit.ovirt.org/#/c/26480/10/packaging/dbscripts/upgrade/03_05_0410_unregistered_ovf_of_entities.sql File packaging/dbscripts/upgrade/03_05_0410_unregistered_ovf_of_entities.sql: Line 14: unregistered_ovf_of_entities_storage_domain unregistered_ovf_of_entities_storage_domain=>fk_unregistered_ovf_of_entities_storage_domain -- To view, visit http://gerrit.ovirt.org/26480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I385fac757f46131ae0c0048b6cf39b78f037e852 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
