Oved Ourfali has uploaded a new change for review. Change subject: docker: include jquery from secured link ......................................................................
docker: include jquery from secured link Previous version included jquery from a non-secured URL (http), which is problematic in case the engine is working with a secured URL (https), so making https the default, and adding an installation note to change that in case needed. Change-Id: I06bd1665ab6c3217c101e6b517ea2bd3b397c052 Signed-off-by: Oved Ourfali <[email protected]> --- M docker-plugin/README M docker-plugin/docker-resources/plugin.html 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/samples-uiplugins refs/changes/45/27645/1 diff --git a/docker-plugin/README b/docker-plugin/README index e6dfcd7..f690672 100644 --- a/docker-plugin/README +++ b/docker-plugin/README @@ -17,6 +17,8 @@ Expose plugin static files to oVirt Engine $ ln -s $PLUGIN_HOME/docker-resources $ENGINE_USR/ui-plugins/docker-resources +2. If using http, and not https (for development reasons), please also change the plugin.html to include the jquery code from http://code.jquery.com/jquery-latest.js (and not https://....). + USAGE: 1. Fill in the DC, Cluster, Template (template that has the requirements above), VM properties, Docker details (image, port mapping and command if needed), and cloud-init data. 2. Run the created VM diff --git a/docker-plugin/docker-resources/plugin.html b/docker-plugin/docker-resources/plugin.html index 83cf229..84f5ec8 100644 --- a/docker-plugin/docker-resources/plugin.html +++ b/docker-plugin/docker-resources/plugin.html @@ -8,7 +8,7 @@ </head> <body> -<script src="http://code.jquery.com/jquery-latest.js";></script> +<script src="https://code.jquery.com/jquery-latest.js";></script> <script type='text/javascript'> var formWindow = null; -- To view, visit http://gerrit.ovirt.org/27645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I06bd1665ab6c3217c101e6b517ea2bd3b397c052 Gerrit-PatchSet: 1 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
