Alon Bar-Lev has posted comments on this change. Change subject: aaa: Remove dependency at builtin on Common config ......................................................................
Patch Set 5: (1 comment) I do not understand... if you had worked to pass the configuration all over... why do you still need that singleton.... and if you use the singleton, why do you need to pass the configuration all over. one contradicts the other. either 10 lines of code with singleton or 250 without... no? http://gerrit.ovirt.org/#/c/27607/5/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java: Line 19: putIfAbsent(conf, "LDAPConnectTimeout", "30"); Line 20: putIfAbsent(conf, "MaxLDAPQueryPartsNumber", "100"); Line 21: putIfAbsent(conf, "LDAPOperationTimeout", "30"); Line 22: putIfAbsent(conf, "LdapQueryPageSize", "1000"); Line 23: } hmmmm.... won't it better to have properties as resource in the exact format load it and iterate? Line 24: Line 25: } Line 26: Line 27: private static void putIfAbsent(Properties props, String key, String value) { -- To view, visit http://gerrit.ovirt.org/27607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1384a99f73ab605b61bce8dcdfd63e222b0001fa Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
