Tal Nisan has posted comments on this change. Change subject: core: New query 'GetAllStorageDomains' to get all storage domains (#783087) ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Looks good to me other than a very minor comment .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java Line 115: * Retrieves all storage domains. I'd add "Retrieves all storage domains with optional filtering" to distinguish it from the getall() method -- To view, visit http://gerrit.ovirt.org/5215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7029027849515480759b5690a379e5362b7f6b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
