mooli tayer has uploaded a new change for review.
Change subject: tools: add snmp oid validation.
......................................................................
tools: add snmp oid validation.
An oid is valid iff 2 <= size() <= 128 and if the first
two sub-identifiers are less than 3 and 40 respectively.
Emtpy values are not valid. a missing value already generates an
exception when getting property.
Change-Id: I2469bfac312eb38dad7de093c8fefe144f75bbb2
Signed-off-by: Mooli Tayer <mta...@redhat.com>
---
M
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/27664/1
diff --git
a/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
b/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
index 3f39e37..f7cf51a 100644
---
a/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
+++
b/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
@@ -211,6 +211,15 @@
}
this.community = new OctetString(community);
this.oid = new OID(oid);
+ if (!this.oid.isValid()) {
+ throw new IllegalArgumentException(
+ String.format(
+ "Invalid oid '%s'",
+ oid
+ )
+ );
+
+ }
}
}
}
--
To view, visit http://gerrit.ovirt.org/27664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2469bfac312eb38dad7de093c8fefe144f75bbb2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mta...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
