Allon Mureinik has posted comments on this change.

Change subject: core: Cleanup VdsUpdateRunTimeInfo
......................................................................


Patch Set 1: (2 inline comments)

yzaslavs:
Agreed, will separate this logic to another patch

mlipchuk:
agreed, will send a new patchset

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 592:                 // else remove from map (for future checks) and set 
the host to non-operational
I'm extracting this change to a different patch, as per yzaslavs' suggestion, 
and will fix the comment there too.

Line 1244:         for (Map.Entry<VmDynamic, VmStatistics> vm_helper : 
_runningVms.values()) {
Done

--
To view, visit http://gerrit.ovirt.org/5203
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief76350281768ceb327b046d526e5450bb3c2bdd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to